On Wed, Nov 13, 2013 at 11:06 PM, "Andrés G. Aragoneses"
<knocte@xxxxxxxxx> wrote:
> Instead of simply ignoring the value passed to --depth
> option when it is zero or negative, now it is caught
> and reported.
>
> This will let people know that they were using the
> option incorrectly (as depth<0 should be simply invalid,
> and under the hood depth==0 didn't mean 'no depth' or
> 'no history' but 'full depth' instead).
'full depth' may be confusing (is it --unshallow?). Other than that
the patch looks fine.
>
> Signed-off-by: Andres G. Aragoneses <knocte@xxxxxxxxx>
> ---
> transport.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/transport.c b/transport.c
> index 7202b77..edd63eb 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -483,6 +483,8 @@ static int set_git_option(struct git_transport_options
> *opts,
> opts->depth = strtol(value, &end, 0);
> if (*end)
> die("transport: invalid depth option '%s'",
> value);
> + if (opts->depth < 1)
> + die("transport: invalid depth option '%s'
> (non positive)", value);
> }
> return 0;
> }
> --
> 1.8.1.2
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html