Lars Hjemli <hjemli@xxxxxxxxx> writes: > The test for reflog parameter to create_branch() should also have tested > for log_all_ref_updates. But there is no good reason not to prepare a > reflog message, so lets just do it. > > Signed-off-by: Lars Hjemli <hjemli@xxxxxxxxx> > --- > > If log_all_ref_updates==1 then the reflog will get an empty message with > your patch. That is better than using an uninitialized message, but I think > it's still better to just prepare a proper message. True, but don't you still need to set log_all_ref_updates while you call write_ref_sha1() for that ref in order to make sure that log_ref_write() sets O_CREAT in oflags? - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html