Re: [PATCH 6/7] test-hg.sh: help user correlate verbose output with email test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2013-11-11 06:42, Felipe Contreras wrote:
> Richard Hansen wrote:
>> It's hard to tell which author conversion test failed when the email
>> addresses look similar.
>>
>> Signed-off-by: Richard Hansen <rhansen@xxxxxxx>
>> ---
>>  contrib/remote-helpers/test-hg.sh | 20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh
>> index 84c67ff..5eda265 100755
>> --- a/contrib/remote-helpers/test-hg.sh
>> +++ b/contrib/remote-helpers/test-hg.sh
>> @@ -209,16 +209,16 @@ test_expect_success 'authors' '
>>  
>>  	>../expected &&
>>  	author_test alpha "" "H G Wells <wells@xxxxxxxxxxx>" &&
>> -	author_test beta "test" "test <unknown>" &&
>> -	author_test beta "test <test@xxxxxxxxxxx> (comment)" "test <test@xxxxxxxxxxx>" &&

Notice the two betas here in the original code.

>> -	author_test gamma "<test@xxxxxxxxxxx>" "Unknown <test@xxxxxxxxxxx>" &&
>> -	author_test delta "name<test@xxxxxxxxxxx>" "name <test@xxxxxxxxxxx>" &&
>> -	author_test epsilon "name <test@xxxxxxxxxxx" "name <test@xxxxxxxxxxx>" &&
>> -	author_test zeta " test " "test <unknown>" &&
>> -	author_test eta "test < test@xxxxxxxxxxx >" "test <test@xxxxxxxxxxx>" &&
>> -	author_test theta "test >test@xxxxxxxxxxx>" "test <test@xxxxxxxxxxx>" &&
>> -	author_test iota "test < test <at> example <dot> com>" "test <unknown>" &&
>> -	author_test kappa "test@xxxxxxxxxxx" "Unknown <test@xxxxxxxxxxx>"
>> +	author_test beta "beta" "beta <unknown>" &&
>> +	author_test beta "beta <test@xxxxxxxxxxx> (comment)" "beta <test@xxxxxxxxxxx>" &&
> 
> Two betas?

See above.  I can change them to beta1 and beta2, or if you'd prefer I
can change them to beta and gamma and increment the subsequent entries.

Thanks,
Richard

> 
>> +	author_test gamma "<gamma@xxxxxxxxxxx>" "Unknown <gamma@xxxxxxxxxxx>" &&
>> +	author_test delta "delta<test@xxxxxxxxxxx>" "delta <test@xxxxxxxxxxx>" &&
>> +	author_test epsilon "epsilon <test@xxxxxxxxxxx" "epsilon <test@xxxxxxxxxxx>" &&
>> +	author_test zeta " zeta " "zeta <unknown>" &&
>> +	author_test eta "eta < test@xxxxxxxxxxx >" "eta <test@xxxxxxxxxxx>" &&
>> +	author_test theta "theta >test@xxxxxxxxxxx>" "theta <test@xxxxxxxxxxx>" &&
>> +	author_test iota "iota < test <at> example <dot> com>" "iota <unknown>" &&
>> +	author_test kappa "kappa@xxxxxxxxxxx" "Unknown <kappa@xxxxxxxxxxx>"
>>  	) &&
>>  
>>  	git clone "hg::hgrepo" gitrepo &&
> 

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]