On 08/11/13 17:10, Torsten Bögershausen wrote: > On 2013-11-07 23.19, Jeff King wrote: >> On Thu, Nov 07, 2013 at 09:58:02PM +0000, Ramsay Jones wrote: >> >>> These patches fix various errors/warnings on the cygwin, MinGW and >>> msvc builds, provoked by the jk/pack-bitmap branch. >> >> Thanks. Your timing is impeccable, as I was just sitting down to >> finalize the next re-roll. I'll add these in. >> >> -Peff > > Side question: > Do we have enough test coverage for htonll()/ntohll(), > or do we want do the "module test" which I send a couple of days before ? Yes, sorry for not bringing that up; I didn't get to try (or even look at) your test patch, because I couldn't 'git am' it. :( I've been meaning to look into why that is, but just haven't had time yet. (I think it may have something to do with your name - I've noticed in the past that any mail with utf8 characters causes problems.) However, I should have alerted Jeff to your patch; sorry about that! ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html