On Thu, Oct 31, 2013 at 1:05 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >> Otherwise we would have to include commit.h. > > Was there a reason why commit.h is not included here, just like > revision.h would include diff.h, so that users of shortlog.h do not > have to worry about including commit.h themselves? Because you can't do: struct diff_options; struct diff_options diffopt; The storage size is not known, but you can do: struct diff_options; struct diff_options *diffopt; -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html