On 31.10.2013, at 10:25, Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote: > Most of these have been sent before, but were not applied for one reason or > another. All of these look fine and sensible to me. Some of the latter patches in the series might be a bit subjective (e.g. I personally don't mind "yoda" conditions at all), but none do harm, and most are a clear improvement. So I am all for applying this. Cheers, Max > > Felipe Contreras (16): > merge: simplify ff-only option > t: replace pulls with merges > pull: cleanup documentation > fetch: add missing documentation > revision: add missing include > shortlog: add missing declaration > branch: trivial style fix > sha1-name: trivial style cleanup > transport-helper: trivial style fix > describe: trivial style fixes > pretty: trivial style fix > revision: trivial style fixes > diff: trivial style fix > run-command: trivial style fixes > setup: trivial style fixes > add: avoid yoda conditions > > Documentation/git-fetch.txt | 3 +++ > Documentation/git-pull.txt | 4 ++-- > builtin/add.c | 2 +- > builtin/branch.c | 3 +-- > builtin/describe.c | 7 +++---- > builtin/diff.c | 2 +- > builtin/merge.c | 11 ++--------- > pretty.c | 2 +- > revision.c | 14 ++++++-------- > revision.h | 1 + > run-command.c | 13 +++++-------- > setup.c | 4 ++-- > sha1_name.c | 1 - > shortlog.h | 2 ++ > t/annotate-tests.sh | 2 +- > t/t4200-rerere.sh | 2 +- > t/t9114-git-svn-dcommit-merge.sh | 2 +- > t/t9500-gitweb-standalone-no-errors.sh | 2 +- > transport-helper.c | 1 + > 19 files changed, 35 insertions(+), 43 deletions(-) > > -- > 1.8.4.2+fc1 > > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail