On 10/30/2013 12:05 PM, Ramkumar Ramachandra wrote:
> Michael Haggerty wrote:
>> diff --git a/remote.c b/remote.c
>> index e42daa8..a5e6c7f 100644
>> --- a/remote.c
>> +++ b/remote.c
>> @@ -825,6 +825,8 @@ static int query_refspecs(struct refspec *refs, int ref_count, struct refspec *q
>> {
>> int i;
>> int find_src = !query->src;
>> + const char *needle = find_src ? query->dst : query->src;
>> + char **result = find_src ? &query->src : &query->dst;
>>
>> if (find_src && !query->dst)
>> return error("query_refspecs: need either src or dst");
>> @@ -833,8 +835,6 @@ static int query_refspecs(struct refspec *refs, int ref_count, struct refspec *q
>> struct refspec *refspec = &refs[i];
>> const char *key = find_src ? refspec->dst : refspec->src;
>> const char *value = find_src ? refspec->src : refspec->dst;
>> - const char *needle = find_src ? query->dst : query->src;
>> - char **result = find_src ? &query->src : &query->dst;
>>
>> if (!refspec->dst)
>> continue;
>
> Why? Is it used in some later patch?
It's just improving the code hygiene in a function that I was reading to
understand the other code affected by the patches. It's unrelated to
the other patches.
Michael
--
Michael Haggerty
mhagger@xxxxxxxxxxxx
http://softwareswirl.blogspot.com/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html