On Sun, Oct 27, 2013 at 09:09:32AM +0100, Thomas Rast wrote: > Josh Triplett <josh@xxxxxxxxxxxxxxxx> writes: > > > On Sun, Oct 27, 2013 at 06:42:44AM +0100, Michael Haggerty wrote: > >> But I don't think that this feature should be given the "-f" short > >> option, as (a) -f often means "force"; (b) it will increase the > >> confusion with --fixup; (c) it just doesn't strike me as being likely to > >> be such a frequently-used option (though if this changes over time the > >> "-f" option could always be granted to it later). > > > > (a) -n often means --dry-run, but for commit it means --no-verify. > > Different commands have different options, and commit doesn't have a > > --force to abbreviate as -f. > > > > (b) If anything, I think the existence of a short option will make the > > distinction more obvious, since -f and --fixup are much less similar > > than --fixes and --fixup. Most users will never type --fixes, making > > confusion unlikely. > > > > (c) Short option letters tend to be first-come first-serve unless > > there's a strong reason to do otherwise. Why reserve 'f' for some > > hypothetical future option that doesn't exist yet? > > No, lately the direction in Git has been to avoid giving options a > one-letter shorthand until they have proven so useful that people using > it in the wild start to suggest that it should have one. > > See e.g. > > http://article.gmane.org/gmane.comp.version-control.git/233998 > http://article.gmane.org/gmane.comp.version-control.git/168748 Fair enough; easy enough to drop -f if that's the consensus. However... > A much better argument would be if it was already clear from the specs > laid out for Fixes that n% of the kernel commits will end up having this > footer, and thus kernel hackers will spend x amount of time spelling out > --fixes and/or confusing it with --fixup to much headache. ...good suggestion: ~/src/linux$ git log --grep='stable@' --oneline --since='1 year ago' | wc -l 2769 ~/src/linux$ git log --grep='stable@' --oneline --since='1 year ago' --pretty=format:%an | sort -u | wc -l 839 Several thousand commits per year by hundreds of unique people seems like enough to justify a short option. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html