Re: [PATCH] for-each-ref: avoid loading objects to print %(objectname)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh
> index 752f5cb..2b4b9a9 100755
[...]
> +test_atom head *objectname ''
> +test_atom head *objecttype ''
[...]
> +test_atom tag *objectname '67a36f10722846e891fbada1ba48ed035de75581'
> +test_atom tag *objecttype 'commit'

Can you quote the *?  I may have become somewhat paranoid, but still.
This is the first use of the *<field> syntax, and test_atom seems
written to correctly quote its arguments, so why risk it? :-)

-- 
Thomas Rast
tr@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]