On Tue, Oct 22, 2013 at 03:36:02PM +0200, Jens Lindström wrote: > In send_pack(), clear the fd passed to pack_objects() by setting > it to -1, since pack_objects() closes the fd (via a call to > run_command()). Likewise, in get_pack(), clear the fd passed to > run_command(). > > Not doing so risks having git_transport_push(), caller of > send_pack(), closing the fd again, possibly incorrectly closing > some other open file; or similarly with fetch_refs_from_pack(), > indirect caller of get_pack(). Thanks, this looks like the right thing to do. You had mentioned earlier in the thread the possibility of just dropping the close() in git_transport_push. I agree that it is not worth going that route, as it serves as a safety check to avoid leaking in early returns (and indeed, in both the fetch and push cases, we can return early without spawning a subprocess when the receiver already has all of the necessary objects). > Signed-off-by: Jens Lindström <jl@xxxxxxxxx> Acked-by: Jeff King <peff@xxxxxxxx> -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html