Re: [PATCH] status: allow branch info color customization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alexander 'z33ky' Hirsch <1zeeky@xxxxxxxxx> writes:

> From: Alexander Hirsch <1zeeky@xxxxxxxxx>
>
> git status -bs (--branch --short) does not seem to allow customization of the
> colors for the local and remote branch.

wt-status can use the following colors:

    WT_STATUS_CHANGED
    WT_STATUS_HEADER
  - WT_STATUS_LOCAL_BRANCH
    WT_STATUS_NOBRANCH
    WT_STATUS_ONBRANCH
  - WT_STATUS_REMOTE_BRANCH
    WT_STATUS_UNMERGED
    WT_STATUS_UNTRACKED
    WT_STATUS_UPDATED

but parse_status_slot() lets you set only these

    WT_STATUS_CHANGED
    WT_STATUS_HEADER
    WT_STATUS_NOBRANCH
    WT_STATUS_ONBRANCH
    WT_STATUS_UNMERGED
    WT_STATUS_UNTRACKED
    WT_STATUS_UPDATED

and this patch makes the configuration mechanism cover all of the
slots by adding parsing code for the missing two.

While I think the intent of the patch makes sense, I have to wonder
if "local" and "remote" without having the "branch" anywhere is
painting us into an unpleasant corner we cannot later get out
of. For example, we might want to show the remote-tracking branch
information (that is where REMOTE_BRANCH color matters in the
current code) in a more detailed way later, which may include where
the source repository resides, either locally on the same host or
remotely over the network, and WT_STATUS_{LOCAL,REMOTE}_REPOSITORY
may be the natural names for the colors to paint the repository
paths/URL in.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]