On Mon, 14 Oct 2013, brian m. carlson wrote: > On Mon, Oct 14, 2013 at 05:25:29PM +0200, Nicolas Vigier wrote: > > The reason that I looked at this documentation in the first place was > > that I was looking at adding an option '-S[<keyid>], --gpg-sign[=<keyid>]' > > to git-rebase, similar to the option in git-commit, so that rebased > > commits can be signed. In git-commit this option takes an optional argument, > > so I think it would make sense to make it optional in git-rebase too. > > It's funny you say that, because I literally started on that yesterday. > I have cherry-pick and revert working, but I haven't gotten to anything > else yet. Feel free to work on it if you're interested, as I probably > won't get around to finishing it for some time. I have a patch for git-am working, but with a small problem : it has to assume that the optional argument to -S does not start with a dash. This is because git-rev-parse --parseopt does not allow us to see the difference between -S-q and -S -q, we don't know if -q is the next option or the argument to -S. Maybe that's the reason why the use of optional argument options with git rev-parse --parseopt is discouraged ? I'm going to send a patch proposal so that rev-parse --parseopt gives an empty argument for an unset optional argument.
Attachment:
pgps9eVP7hhjC.pgp
Description: PGP signature