Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > Matthieu Moy wrote: >> Jens Lehmann <Jens.Lehmann@xxxxxx> writes: > >>> static struct lock_file lock_file; >>> +#define SUBMODULE_WITH_GITDIR ((const char *)1) >> >> I don't like very much hardcoded addresses like this. Are you 100% sure >> address 1 will never be returned by xstrdup on any platform? The risk is >> small if not negligible, but I'm unconfortable with this. > > I haven't checked what the standards say, but in practice I think it's > okay. [...] We use (void *) 1 in the same way a few places currently. OK, fine with me. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html