On Fri, Oct 11, 2013 at 04:43:07PM -0700, Jonathan Nieder wrote: > "By default" means "when allowed to make its own choice", right? (i.e., > the behavior git never gave libcurl a chance to try :)) > > Makes sense. Yes, at least according to Daniel Stenberg. I don't believe it is ever triggered the way that git calls curl with CURLOPT_READFUNCTION, but I can't be certain since I haven't looked at the source code. > Style: git tends to omit the '= 0' implicit for globals, since they are > already 0 by default. Okay. > /* > * Multi-line comments in git have the starting and ending comment > * delimiters on their own lines, like this. > */ It wasn't clear from the existing code which way was being used, and the CodingGuidelines file didn't seem to cover it. I'll send a patch. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Attachment:
signature.asc
Description: Digital signature