Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 9, 2013 at 11:11 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> Paolo Giarrusso wrote:
>
>> Seeing the email, I wonder whether there's hope something like that
>> can be preserved in an email, and whether the code should use some
>> escape sequence instead.
>
> Yes, please.  Mind if I amend it to
>
>         printf "%s\r" "$revcount/$revmax ($createcount)" >&2
>
> ?

Please do go ahead, by all means (arguably as a different commit, but
those are minor details).

> [...]
>>>         say()
>>>         {
>>>                 if [ -z "$quiet" ]; then
>>>                         echo "$@" >&2
>>>                fi
>>>         }
>
> I agree with the other reviewers that this should be fixed to use
> printf, too, but that's another topic.
Seconded.

-- 
Paolo G. Giarrusso - Ph.D. Student, Philipps-University Marburg
http://www.informatik.uni-marburg.de/~pgiarrusso/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]