On Sun, Oct 06, 2013 at 09:48:29PM +0100, Ramsay Jones wrote: > Sparse issues an "'git_parse_unsigned' was not declared. Should it > be static?" warning. In order to suppress this warning, since this > symbol only requires file scope, we simply add the static modifier > to its declaration. Thanks. This one is my fault. Commit 7192777 refactors git_parse_ulong, which is public, into a more generic function. But since we kept the git_parse_ulong wrapper, only that part needs to be public; nobody outside the file calls the lower-level git_parse_unsigned. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html