Re: [PATCH v2 44/44] request-pull: rewrite to C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felipe Contreras wrote:
>  builtin/request-pull.c | 275 +++++++++++++++++++++++++++++++++++++++++++++++++
>  git-request-pull.rb    | 199 -----------------------------------

My head started hurting beyond part 15: I need more coffee ;)

Right now, I'm looking at these two side by side:
https://github.com/felipec/git/blob/724e759e777e21ddc1e1a77b5bad16a301dffe38/git-request-pull.rb
https://github.com/felipec/git/blob/68dd43654e265d8ebe42daf43646c636d3f0ff99/builtin/request-pull.c

Truly beautiful. No more
kitchen-sink-dependency-embedded-lua-language-war-flame fud.

I look forward to more eyes, and a clean merge. Part 2 is missing a
commit message, but the rest of your series looks very reasonable.
Thanks a lot for doing this! You've opened the door for an incredible
amount of learning opportunities.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]