Re: [PATCH v2 14/44] ruby: bind dwim_ref()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 29, 2013 at 12:17 AM, Ramkumar Ramachandra
<artagnon@xxxxxxxxx> wrote:
> Felipe Contreras wrote:
>>  static void git_ruby_init(void)
>>  {
>>         rb_define_global_function("setup_git_directory", git_rb_setup_git_directory, 0);
>>         rb_define_global_function("for_each_ref", git_rb_for_each_ref, 0);
>> +       rb_define_global_function("dwim_ref", git_rb_dwim_ref, 1);
>>  }
>
> At this point, global functions is probably the way to go. We might
> like to put them in classes to create a beautiful Rugged-inspired API
> in the future.

We might, for certain things, but as I explained before, we can't
really do the same.

test1 = Rugged::Repository.new("test1")
test2 = Rugged::Repository.new("test2")

How are we supposed to do this with Git's code? If Git's code can only
work with one repository at a time, I think the Ruby bindings should
reflect that as well.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]