Thanks. On Sun, Sep 22, 2013 at 10:43 PM, Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote: > Brandon Casey wrote: >> Ensure buffer length is non-zero before attempting to access the last >> element. >> >> Signed-off-by: Brandon Casey <drafnel@xxxxxxxxx> >> --- >> contrib/credential/gnome-keyring/git-credential-gnome-keyring.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c >> index 1081224..8ae2eab 100644 >> --- a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c >> +++ b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c >> @@ -315,7 +315,7 @@ static int credential_read(struct credential *c) >> { >> line_len = strlen(buf); >> >> - if(buf[line_len-1]=='\n') >> + if(line_len && buf[line_len-1] == '\n') > > The style is if (). > > -- > Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html