Re: [PATCH] format-patch: print in-body "From" only when needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> So I think it should be possible to fix our internal consumers 
> ... I'm a little wary
> of external consumers that might get confused by it.

Yeah, thanks for a good summary of analysis.  I agree that it would
be doable, but it is dubious if it is worth it.

>
> ---
> diff --git a/builtin/log.c b/builtin/log.c
> index 77d0f5f..77564fd 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> @@ -1235,6 +1235,8 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
>  		rev.no_inline = 1;
>  	}
>  
> +	from = xstrdup(git_committer_info(IDENT_NO_DATE));
> +
>  	/*
>  	 * Parse the arguments before setup_revisions(), or something
>  	 * like "git format-patch -o a123 HEAD^.." may fail; a123 is
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]