Re: [PATCH] Make gitk work reasonably well on Cygwin.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 31 Jan 2007, Mark Levedahl wrote:

> 1) Regarding the size of the patch. I tried many different approaches to 
> getting the layout to work on Cgywin as well as Linux, ultimately the 
> only approach that worked required changing the very top level structure 
> containing the Tk widgets. As the style used names all widgets using 
> their parents, every widget's name is changed. This makes the patch seem 
> more complex than it is, many changes are just changing names.

Well, I don't like the size mainly because it makes it absolutely 
impossible for me to review it. After 20 lines of just renamed widget 
paths I really lose all my concentration.

And then I find that you also fixed whitespace breakage, which does not 
belong in this patch.

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]