Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 19, 2013 at 9:37 AM, Junio C Hamano <junio@xxxxxxxxx> wrote:
> On Sep 18, 2013 11:08 PM, "Piotr Krukowiecki" <piotr.krukowiecki@xxxxxxxxx>
> wrote:
>>
>> On Wed, Sep 11, 2013 at 9:16 PM, Jeff King <peff@xxxxxxxx> wrote:
>> > I would prefer the static wrapper solution you suggest, though. It
[...]
>> > it still ends up as a single function call). The downside is that it has
>> > to be remembered at each site that uses strcasecmp, but we do not use
>> > pointers to standard library functions very often.
>>
>> Is it possible to add a test which fails if wrapper is not used?
>
> No test needed for this, as compilation or linkage will fail, I think.

But only when someone compiles on MinGW, no?

-- 
Piotr Krukowiecki
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]