Re: [PATCH] fetch-pack.c: show correct command name that fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 18, 2013 at 11:16:15AM -0700, Junio C Hamano wrote:

> I wondered if this is something we can have a test for easily.
> Unlike the "--upload-pack" option, there is no way for the receiving
> end to choose which index-pack (or unpack-objects) to run, but we
> may force a failure by temporarily futzing with PATH to make a dummy
> git-index-pack that always fails to be found or something silly like
> that.

You can feed a bogus pack, which will cause either to fail reliably. I'm
not sure if that counts as "easy" though. :) Munging PATH is probably
simpler.

> >  fetch-pack.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)

Patch looks good to me, too.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]