Re: 1.8.4 rebase regression?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patrick Welche <prlw1@xxxxxxxxx> writes:

> On Tue, Sep 17, 2013 at 11:23:51AM +0200, Matthieu Moy wrote:
>> Patrick Welche <prlw1@xxxxxxxxx> writes:
>> 
>> > Got it: the change between 1.8.3.4 and 1.8.4 is that colour is on by
>> > default. If I take 1.8.3.4 and git -c color.ui=always log, I see
>> > the same ESC codes => not a regression! I'll just have to sort my
>> > box out if I want colour. (The only oddity is that git status is
>> > correctly colourful.)
>> 
>> Maybe you disabled the pager for "git status"?
>
> Interesting: I didn't disable it on purpose, but indeed, it is not
> used for status.

Ah, my bad. Whether the pager should be enabled by default for status
led to a lot of debates here, and I thought the conclusion was yes. But
I'm the one having it enabled by default:

[pager]
        status = true

> Can't believe this:
>
> $ echo $PAGER
> more
>
> unset PAGER, and git diff is fine...

less will be a much better pager than more, indeed. The default behavior
of less is sometimes anoying (open full-page, and 'q' restores the
terminal, which is very inconvenient for short output), but if you
didn't set $LESS, then Git will set it for you to something appropriate
for git pager.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]