On Fri, Sep 13, 2013 at 9:56 PM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: >> +#ifdef __MINGW32__ >> +#ifdef __NO_INLINE__ > > Why do you want to push this insane workaround for a clear Mingw bug? To be frank, because Git is picking up patches much quicker than MinGW does, and I want a solution ASAP. Although I of course agree that fixing the real issue upstream in MinGW is the better solution. > Please have mingw just fix the nasty bug, and the git patch with the I'll try to come up with a MinGW patch in parallel. > trivial wrapper looks much simpler than just saying "don't inline > anything" and that crazy block of nasty mingw magic #defines/. It may look simpler, but as outlines in this thread it's less maintainable because you need to remember to use the wrapper. And people tend to forget that no matter how loudly you document that. If we can make the code more fool proof we IMHO should do so. -- Sebastian Schuberth -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html