On Wed, Sep 11, 2013 at 11:51 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > It seems that compat/poll/poll.c also defines _WIN32_WINNT (but only > with _MSC_VER defined). The change to git-compat-util.h in this > patch avoids redefinition for both MinGW and MSVC case. Do you also > need to have this, too? In my patch I did not change poll.c because I did only check this issue with MinGW, not MSVC, so I never ran into the _MSC_VER code path. Back in 1.8.3 git-compat-util.h did define _WIN32_WINNT for both MinGW and MSVC, which is why in my patch I had to add the #ifndef / #endif. But I believe it's good to have these guards for both MinGW and MSVC, actually. > Here is what I tentatively queued on top of the three from Karsten, > and your "Fix stat definitions". Looks good to me, thanks! -- Sebastian Schuberth -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html