On Sun, Sep 08, 2013 at 08:36:35PM -0400, Eric Sunshine wrote: > On Sun, Sep 8, 2013 at 4:36 AM, Jeff King <peff@xxxxxxxx> wrote: > > When we are parsing an integer or unsigned long, we use > > the strto*max functions, which properly set errno to ERANGE > > if we get a large value. However, we also do further range > > checks after applying our multiplication factor, but do not > > set ERANGE. This means that a caller cannot tell if an error > > was caused by ERANGE or if the input was simply not a valid > > number. > > > > This patch teaches git_parse_signed and git_parse_unsigned > > reliably set ERANGE for range errors, and EINVAL for other > > Missing "to": s/reliably/to reliably/ > > Or, if you don't like splitting the infinitive: > > s/reliably set ERANGE/to set ERANGE reliably/ Thanks. That is what I get for last-minute tweaking of the commit message (and I am OK with splitting the infinitive :) ). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html