On Mon, Sep 9, 2013 at 12:51 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >> If the version is 'v1.8.4-rc1' that is the version, and there's no need >> to change it to anything else, like 'v1.8.4.rc1'. >> >> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx> >> --- >> GIT-VERSION-GEN | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN >> index b0db139..2b9fd2f 100755 >> --- a/GIT-VERSION-GEN >> +++ b/GIT-VERSION-GEN >> @@ -24,7 +24,6 @@ then >> VN="$VN-dirty" >> ;; >> esac >> - VN=$(echo "$VN" | sed -e 's/-/./g') >> else >> VN="$DEF_VER" >> fi > > The log message of 5c7d3c95 (Allow building of RPM from interim > snapshot., 2006-01-16) leaves a lot to be desired, but I do remember > that this was added due to user request. Before that commit, we did > not strip dashes, and RPM packaging did not like dash in the version > name, hence folks on RH and derived distributions could not package > the software out of the box themselves. Of course they could, by doing the replace themselves, or by simply using a 'version' file. Didn't you just recently suggested somebody to do exactly that? > I do not offhand know if that RPM limitation was lifted. I do not > know if there are other packagers with a similar limitation that > have been relying on this version mangling, either. This change may > end up being a regression for these users. Of course not. First of all, who exactly is packaging release candidates nowadays? And second, why they can't they use the existing tools, like the 'version' file? The information behind the commit 5c7d3c95 is basically non-existant, as I cannot even find a patch for that change in the mailing list. I guess you decided the commit was so trivial it didn't merit a patch for review and discussion. Anyway, it happened before the 'version' file option was present, so it's quite likely they (whatever "they" might be) would not have any issue. > The mangling is done only for auto-generated names, so I suspect > that anybody who wanted the dash in their version names for whatever > reason has already been using the "version file" escape hatch (or > nobody had a desparate need to use dash instead of dot). So, let me get this straight; the nominal version of Git has a dash (v1.8.3-rc1), but the internal version of doesn't (1.8.3.rc1), there is no real reason for that, except that you say "some people" need it that way, but then you say the people that need it in the nominal way should use the 'version' file. Why couldn't the people that want the non-nominal form use the 'version' file instead? It doesn't follow. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html