Re: [PATCH v2 2/3] fetch-pack: use index-pack --unpack-limit instead of unpack-objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 06, 2013 at 07:46:02AM +0700, Nguyen Thai Ngoc Duy wrote:

>  static int get_pack(struct fetch_pack_args *args,
> -		    int xd[2], char **pack_lockfile)
> +		    int xd[2], char **pack_lockfile_p)
>  {
>  	struct async demux;
> -	const char *argv[22];
> +	const char *argv[23];
>  	char keep_arg[256];
> -	char hdr_arg[256];
> +	char unpack_limit_arg[256];

Perhaps it is time to convert this to use argv_array? I think you could
even get rid of the fixed-size buffers, too, with argv_array_pushf().

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]