On Sat, Sep 7, 2013 at 11:52 AM, Nicolas Pitre <nico@xxxxxxxxxxx> wrote: > On Fri, 6 Sep 2013, Nguyễn Thái Ngọc Duy wrote: > >> >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> >> --- >> Should be up to date with Nico's latest implementation and also cover >> additions to the format that everybody seems to agree on: >> >> - new types for canonical trees and commits >> - sha-1 table covering missing objects in thin packs > > Yes, I've tweaked the format again. I've implemented the code needed to > carry canonical commit and tree objects in pack v4. And things are much > simpler if the canonical commit and tree types are identical to pack v2. > Therefore the new types are used for the pack v4 optimized commit and > tree representations. Phew, index-pack finally produces .idx identical to packv4-create output. Yeah using new types for v4 tree and commit should help. I have a lot of "if (packv4 && type == OBJ_TREE)" tests, now they become "if (type == OBJ_PV4_TREE)". Now rebasing on your tree.. Next step: thin pack support in index-pack, then export/move code in packv4-create to support v4 in pack-objects. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html