Junio C Hamano <gitster@xxxxxxxxx> writes: > Christian Couder <chriscool@xxxxxxxxxxxxx> writes: > >> + obj_type = sha1_object_info(object, NULL); >> + repl_type = sha1_object_info(repl, NULL); > > That we can do this is somewhat curious.... Note that this was a comment on the sha1_object_info() API, which, unlike read_sha1_file() API, does not seem to interact with the "replace" mechanism. I _think_ that needs to be rethought by checking each call site, but for the purpose of this series, I think this is the best we can do in this patch. Will queue the whole series. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html