Re: [PATCH v5 6/6] status: add missing blank line after list of "other" files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes:

> Junio C Hamano <gitster@xxxxxxxxx> writes:
>
>> Matthieu Moy <Matthieu.Moy@xxxxxxx> writes:
>>
>>> List of files in other sections ("Changes to be committed", ...) end with
>>> a blank line.
>>
>> It is not like we want to add a blank line at the end of each
>> element; it is rather that we want to have a blank line between each
>> element, so that they can have a bit of breathing room between them.
>
> Well, "between each element, and at the end of the output" sounds a lot
> like "after each element" ;-).

There is a difference between terminator and separator semantics.

LF is a line terminator; it is attached to the end of each line, it
does not come between each pair of adjacent lines. Hence a text file
ends with a LF.

A blank line that separates each C function in our sources is a
separator.  That is why a patch that does

	@@ -99,3 +99,8 @@ int false(void)
	 {
	 	return 0;
	 }
	+
	+int true(void)
        +{
        +	return 1;
	+}

does not add a trailing blank line at the end.

And I am saying that the blank lines in "status" output should be
separators, not terminators of sections.

But see the other message.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]