On Thu, 5 Sep 2013, Duy Nguyen wrote: > On Thu, Sep 5, 2013 at 11:40 AM, Nicolas Pitre <nico@xxxxxxxxxxx> wrote: > > On Thu, 5 Sep 2013, Duy Nguyen wrote: > > > >> On Thu, Sep 5, 2013 at 11:12 AM, Nicolas Pitre <nico@xxxxxxxxxxx> wrote: > >> > Many other bugs have now been fixed. A git.git repository with packs > >> > version 4 appears to be functional and passes git-fsck --full --strict. > >> > >> Yeah I was looking at the diff some minutes ago, saw changes in > >> pack-check.c and wondering if fsck was working. I'll add v4 support to > >> index-pack. > > > > Beware that the tree delta encoding has changed a little. This saved up > > to 2% on some repos. > > Thanks for the heads up. > > > I'll probably change the encoding to incorporate the escape hatch > > for path and name references as discussed previously. this is now committed. I don't think there should be any more pack format changes at this point. Now the pack index v3 probably needs to be improved a little, again to accommodate completion of thin packs. Given that the main SHA1 table is now in the main pack file, it should be possible to still carry a small SHA1 table in the index file that corresponds to the appended objects only. This means that a SHA1 search will have to first use the main SHA1 table in the pack file as it is done now, and if not found then use the SHA1 table in the index file if it exists. And of course nth_packed_object_sha1() will have to be adjusted accordingly. Nicolas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html