Re: [PATCH v3] Teach git to change to a given directory using -C option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 4, 2013 at 2:36 AM, Nazri Ramliy <ayiehere@xxxxxxxxx> wrote:
> On Wed, Sep 4, 2013 at 6:46 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> I do not care too deeply either way, but I am curious if there was a
>> reason why you changed the earlier <directory> to <path>?  Somehow,
>> when we _know_ a path has to be a directory, I find it easier on the
>> readers to spell that out, instead of saying "this is a path",
>> implying that it could be a directory, a regular file, or even
>> non-existent.
>
> Eric made me do it :). Personally I prefer the non-ambiguous "directory"
> over "path". In fact, "directory" is used in the error message spat out
> by git:
>
>     $ git --work-tree
>     No directory given for --work-tree.
>     ...
>
>     $ git --git-dir
>     No directory given for --git-dir.
>     ...
>     $
>
> I think changing "<path>" to "<directory>" wherever appropriate in
> git.txt would be an improvement. Tangent: <dir> is shorter but that
> might not be easy on the translators.

Such a terminology change is orthogonal to the patch adding -C
support, so if you do pursue it, the terminology change should be a
separate patch (either preparatory or follow-up to the -C patch).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]