Junio C Hamano <gitster@xxxxxxxxx> writes: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >> Split into a separate helper function get_commit() so that the part that >> finds the relevant commit, and the part that does something with it >> (handle tag object, etc.) are in different places. >> >> No functional changes. > > Actually, the old code used to use commit unchecked if e->item->type > said it is OBJ_COMMIT but e->item was somehow NULL. The new code > checks ... Nah, I am an idiot. We will segfault where we check e->item->type before reaching that far down the code either way, so this is really a no-op but makes it easier to fix (if we wanted to---I do not think it matters that much). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html