On Tue, Sep 03, 2013 at 10:04:19AM -0700, Jonathan Nieder wrote: > > It depends on the change, I suppose. I agree, changing 3k+ lines just > > to avoid yoda conditions... I doubt the gain worth the code churn. > > Especially when the idiom being changed is not even being made better. > ;-) Yes. IMHO it is not just "not worth the churn" but actively making the code less readable. > While at it, I rerolled the other patches from the series to clarify > their commit messages (replacing "fix <something>" with a fuller > description). The series looks fine to me, modulo the fix up in v2 of 4/4. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html