On 09/03/2013 04:16 AM, Eric Sunshine wrote: > When you decomposed the monolithic test from v1 into individual tests, > you dropped a couple cases ("fatal: unknown option'" and "fatal: > unterminated single-quote"). Was this intentional? Yes. The v3 patch 7 changed the set of error messages to be covered. > The leading '-' on '-EOF' allows you to indent the content of the > heredoc and the terminating EOF, which makes the test read nicely: Very nice. Fixed for next iteration. Thanks, -Brad -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html