From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
>
>> diff --git a/t/t6050-replace.sh b/t/t6050-replace.sh
>> index 0b07a0b..5dc26e8 100755
>> --- a/t/t6050-replace.sh
>> +++ b/t/t6050-replace.sh
>> @@ -122,9 +122,9 @@ test_expect_success '"git replace" listing and deleting' '
>> test "$HASH2" = "$(git replace -l)" &&
>> test "$HASH2" = "$(git replace)" &&
>> aa=${HASH2%??????????????????????????????????????} &&
>> - test "$HASH2" = "$(git replace -l "$aa*")" &&
>> + test "$HASH2" = "$(git replace --list "$aa*")" &&
>> test_must_fail git replace -d $R &&
>> - test_must_fail git replace -d &&
>> + test_must_fail git replace --delete &&
>> test_must_fail git replace -l -d $HASH2 &&
>
> Is this sort of change a good idea? A person reading the code, but not
> familiar with this particular patch, might not understand the
> seemingly random choice of short versus long option usage. Such a
> person might be led to wonder if there is some subtle difference
> between the short and long forms,
I don't think that we should care about people who might wonder if
there are subtle differences between short and long forms, because of
such tests.
The doc says that there is no difference, and there is also no
difference in other git commands, and git replace is an advanced
command, and very few regular users probably read tests, ...
> and then unnecessarily spend time
> digging into the code and documentation in an attempt to figure it
> out. Alternately, someone reading the code might be led to assume that
> the person who added the tests was being sloppy.
Why not just assume that the person who added the tests is so great as
to even take care of testing the long options names?
> Hopefully, t0040-parse-options should already be proof enough that
> long options are correctly handled,
Yeah, indeed!
> but if you really want to test
> them here too, it seems like a separate test would be more appropriate
> than randomly changing short form options to long in various tests.
Introducing some randomness in tests also has some value, you
know. And at the same time it doesn't even slow down the test suite
while adding separate tests would slow it down, and make readers spend
more time reading the whole test suite, and would be a bigger burden
for git developers to maintain for no good reason.
Best,
Christian.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html