On Fri, Aug 30, 2013 at 10:08:53PM +0200, Jens Lehmann wrote: > Am 30.08.2013 21:51, schrieb Jens Lehmann: > > Am 30.08.2013 21:40, schrieb Jens Lehmann: > >> Am 29.08.2013 23:23, schrieb Matthieu Moy: > >>> Jens Lehmann <Jens.Lehmann@xxxxxx> writes: > >>> > >>>> Am 29.08.2013 15:05, schrieb Matthieu Moy: > >>> Because of the missing quotes around $for_status, it seems the test is > >>> unconditionnaly true: > >>> > >>> $ test -n t ; echo $? > >>> 0 > >>> $ test -n ; echo $? > >>> 0 > > Right you are, I did not notice the missing "" in my review. Looks like > we also should add one or more tests making sure that submodule summary > and status never honor the ignore settings. How do we want to handle this? I can send a reroll and include some new tests, but if this code is going away, then there's no point. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Attachment:
signature.asc
Description: Digital signature