On Fri, Aug 30, 2013 at 8:05 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:
>> Acked-by: Jakub Narębski <jnareb@xxxxxxxxx>
>> Tested-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
>> Tested-by: Simon Ruderich <simon@xxxxxxxxxxxx>
>> ---
>> gitweb/gitweb.perl | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index f429f75..ad48a5a 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -6631,6 +6631,7 @@ sub git_blame_common {
>> $hash_base, '--', $file_name
>> or die_error(500, "Open git-blame --porcelain failed");
>> }
>> + binmode $fh, ':utf8';
Should be $fd, not $fh.
> [Fri Aug 30 17:48:17 2013] gitweb.perl: Global symbol "$fh" requires
> explicit package name at /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl line 6634.
> [Fri Aug 30 17:48:17 2013] gitweb.perl: Execution of /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl aborted due to compilation errors.
I wonder how it passed Ævar and Simon tests. Perhaps proposal had $fd?
--
Jakub Narebski
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html