On 08/29/2013 01:28 PM, Junio C Hamano wrote:
> Brad King <brad.king@xxxxxxxxxxx> writes:
>> - if (!(flag & REF_ISPACKED) || flag & REF_ISSYMREF) {
>> + if (!(type & REF_ISPACKED) || type & REF_ISSYMREF) {
>
> Hits from "git grep REF_IS" tell me that all users of REF_IS* symbol
> that check if a bit is on in a word does so against "flag" (either a
> variable called "flag", "flags", or a structure member ".flag").
>
> This change is making things less consistent, not more, I am afraid.
Okay, I removed this part of the change. It makes the commit
simpler anyway.
-Brad
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html