On Wed, Aug 28, 2013 at 3:54 PM, Antoine Pelisse <apelisse@xxxxxxxxx> wrote: > On Wed, Aug 28, 2013 at 10:48 PM, Felipe Contreras > <felipe.contreras@xxxxxxxxx> wrote: >> On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy >> <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: >>> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: >>> >>>> + echo greg >> content && >>>> + git add content && >>>> + git commit -m one >>> >>> test_commit would make it shorter. >> >> And it would make it inconsistent with the rest of the script. >> >>>> + bzr log | grep "^committer: " > ../actual >>>> + ) && >>>> + >>>> + echo "committer: Grégoire <committer@xxxxxxxxxxx>" > expected && >>> >>> Git's source code usually says >../actual and >expected, without space >>> after '>'. >> >> Not that usually: >> >> % git grep ' > ' t/*.sh | wc -l >> 1943 > > There are many false positive in that count. > > As in this one: > $ git grep ' >[^ ]' -- t/*.sh | wc -l > 10354 Ten thousand is still a lot, and the claim remains: it's far from unusual to follow this style. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html