On Mon, Aug 26, 2013 at 05:57:18PM -0400, Jeff King wrote: > On Mon, Aug 26, 2013 at 04:59:01PM -0400, Jeff King wrote: > > > Hmm. I wonder if fgetc is a macro in uclibc? Just grepping their > > stdio.h, it looks like that is a possibility. > > > > I think they are probably wrong to do so (but I'd have to check the > > standard). However, the cleaner workaround would probably be to call the > > fgetc struct member something else. > > Nope, it's allowed. I think we should do the patch below: > > -- >8 -- > Subject: config: do not use C function names as struct members > [...] > > Instead, we can simply use non-colliding names. Yes, this sounds like a better idea to me. So, FWIW, +1 from me. > > Signed-off-by: Jeff King <peff@xxxxxxxx> > --- > config.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > [...] -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html