On Sat, Aug 24, 2013 at 10:41:42PM -0700, Jonathan Nieder wrote:
> Jeff King wrote:
>
> > So we are necessarily reconstructing based on what we know of the
> > syntax. And I think that your rule is OK, because we know that refnames
> > cannot contain a colon.
>
> What happens with expressions like HEAD^{/test:}?
Ugh, right. Names are more than just refnames.
So I think the only way to do this robustly is to ask get_sha1 to
remember more about what happened. We might even be able to get away
without teaching get_sha1_with_context anything else; it already records
the path, so we should be able to just check whether that is non-empty.
But we use an object_array to store the list of objects, and it has no
room for such a bit. So we'd probably want to refactor that, too.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html