Re: t3010 broken by 2eac2a4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 22, 2013 at 7:15 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
> On Thu, Aug 22, 2013 at 7:12 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:
>>
>>> Status update: For the 'pathx' directory created by the t3010 test,
>>> directory_exists_in_index() returns false on OSX, but true is returned
>>> on Linux.
>>
>> Because a regular pathx/ju is in the index at that point, the
>> correct answer directory_exists_in_index() should give for 'pathx'
>> is "index_directory", not "index_nonexistent", I think.
>
> directory_exists_in_index() and directory_exists_in_index_icase() are
> behaving differently. You can replicate the problem on Linux by
> enabling core.ignorecase in the test (sans gmail whitespace damage):
>
> -->8--
> diff --git a/t/t3010-ls-files-killed-modified.sh b/t/t3010-ls-files-killed-modif
> index 3120efd..8c76160 100755
> --- a/t/t3010-ls-files-killed-modified.sh
> +++ b/t/t3010-ls-files-killed-modified.sh
> @@ -89,7 +89,7 @@ test_expect_success 'git ls-files -k to show killed files.' '
>         : >path9 &&
>         touch path10 &&
>         >pathx/ju/nk &&
> -       git ls-files -k >.output
> +       git -c core.ignorecase=true ls-files -k >.output
>  '
> -->8--

I sent a patch [1] which resolves the problem, although the solution
is not especially pretty (due to some ugliness in the existing
implementation).

[1]: http://thread.gmane.org/gmane.comp.version-control.git/232796
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]