Re: [PATCH] Document the HTTP transport protocols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 22, 2013 at 5:00 AM, Jeff King <peff@xxxxxxxx> wrote:
> On Wed, Aug 21, 2013 at 08:45:13PM +0700, Nguyen Thai Ngoc Duy wrote:
>
>>  On the topic, C Git's (maybe) violations on this spec are:
>>
>>   - The client does not strip trailing slashes from $GIT_URL before
>>     sending to the server, as described in section "URL Format".
>
> Yeah. We get the basic gist right by not adding an extra "/" if there is
> already a trailing slash (so you do not have http://host/path//info/refs";).
> But we do not go out of our way to remove multiple slashes that the user
> hands out (either at the end or in the middle of the URL). I doubt that
> it matters in practice.

It may make writing rewrite/matching patterns in http server a tiny
bit harder, but should not be a big deal. I agree with Junio this
could be something a new contributor can work on to get familiar with
(scary, imo) transport/connect code.

I agree with the rest of your comments that those "violations" do not
matter much (when I raised them I did not mean "fix Git", just
checking if I missed anything) and the document is ok as-is.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]