Stefan Beller <stefanbeller@xxxxxxxxxxxxxx> writes: > The condition as it is written in that line was most likely intended to > check for the pointer passed to free(), rather than checking for the > 'repo_abbrev', which is already checked against being non null at the > beginning of the function. [...] > - if (repo_abbrev) > + if (*repo_abbrev) > free(*repo_abbrev); But now the test is useless, because free(NULL) is defined to be a no-op. -- Thomas Rast trast@{inf,student}.ethz.ch -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html