Re: [PATCH] Git segmentation faults if submodule path is empty.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jharrod LaFon <jlafon@xxxxxxxxxxxx> writes:

> I will keep trying this until it's perfect, and I thank you for
> the help.  When I resubmit this, would you like me to include your
> sign-off line as well?

If the one I attached at the end of the message you are responding
to looks fine to you, I'd just apply it without having you to
reroll.

> Also, the end of the test script was not included in your message.  

Sorry, but I am not sure what you meant by this.

I reworked your example to make it the second test in an existing
test script.  There are many existing tests after that so it is
natural that we wouldn't see the end of the file in the patch
context.

>> diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
>> index 5ee97b0..a39d074 100755
>> --- a/t/t7400-submodule-basic.sh
>> +++ b/t/t7400-submodule-basic.sh
>> @@ -18,6 +18,16 @@ test_expect_success 'setup - initial commit' '
>> 	git branch initial
>> '
>> 
>> +test_expect_success 'configuration parsing' '
>> +	test_when_finished "rm -f .gitmodules" &&
>> +	cat >.gitmodules <<-\EOF &&
>> +	[submodule "s"]
>> +		path
>> +		ignore
>> +	EOF
>> +	test_must_fail git status
>> +'
>> +
>> test_expect_success 'setup - repository in init subdirectory' '
>> 	mkdir init &&
>> 	(
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]