On Sun, Aug 18, 2013 at 4:29 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > >> One of the fixes in this patch addresses an oversight in >> 180bad3d10fe3a7f (rebase -i: respect core.commentchar, 2013-02-11) >> which is already in 'maint'. Should I split this patch in two so that >> the one fix can be applied to 'maint'? > > We are so close to 1.8.4 final and I do not think it makes much > difference in practice, but if we were shooting for the ideal, yeah, > as that part of the patch could make core.commentchar useful for > rebase-i users who are still on 1.8.3.X maintenance track. I sent a v2 [1] of this submission which does split the patch into two parts: one for 'maint' and one for 'next', with appropriate commit messages. The actual changes to git-rebase--interactive.sh are identical between v1 and v2. [1]: http://git.661346.n2.nabble.com/PATCH-v2-0-2-fix-cases-of-rebase-i-ignoring-core-commentchar-td7594009.html -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html