Stefan Beller <stefanbeller@xxxxxxxxxxxxxx> writes:
> I have got an idea regarding the send-email. If there are no recipients
> given, it could propose recipients using the new 'git contacts'
> This would help people new to projects to not forget people, who may have
> the most knowledge reviewing that specific patch.
>
> Unfortunately I cannot read/write perl, so I cannot solve it
> myself in the near future, but I'd put it on my todo list for later.
> ---
> git-send-email.perl | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 2162478..a34723d 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -757,6 +757,12 @@ $sender = sanitize_address($sender);
>
> my $prompting = 0;
> if (!@initial_to && !defined $to_cmd) {
> + if (git contacts is available) {
> + proposed senders = git contacts on the same range or set of patches
> + print "Suggesting these receivers:\n"
> + print proposed senders
> + }
> +
> my $to = ask("Who should the emails be sent to (if any)? ",
> default => "",
> valid_re => qr/\@.*\./, confirm_only => 1);
Cute.
It is OK while "contacts" is in contrib/, because people who has
"git contact" are those who opted into the heuristics of implemented
by that script. But if we are to eventually move the script out of
the contrib/ area, we may have to restrict "is available" a bit
tighter. Not everybody has to agree with its heuristics before the
script moves out of the contrib/ area, so there will be users who
are annoyed by the suggestion the script makes, which may not suit
their needs at all.
For contributors of _this_ list, the above will not kick in at all,
as they should always have sendemail.to set to the list, and
@initial_to will not be empty for them.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html